On Sun, 2019-06-16 at 00:12 -0700, Eric Biggers wrote: > > The actual crypto in this driver, on the other hand, looks very outdated and > broken. Apparently it's implementing some Cisco proprietary extension to WEP > that uses a universal hashing based MAC, where the hash key is generated from > AES-CTR. But the MAC is only 32 bits, and the universal hash (MMH) is > implemented incorrectly: there's an off-by-one error in emmh32_final() in the > code that is supposed to be an optimized version of 'sum % ((1ULL << 32) + 15)'. > > Do we know whether anyone is actually using this, or is this just another old > driver that's sitting around unused? I'd guess the latter, though as recent as 2015 Ondrej (CC'ed now) actually changed something in the driver that wasn't just cleanups ... Remove at least this weird Cisco WEP-with-AES-key-generation mode? That must pre-date even TKIP? johannes
