On Fri, Jun 14, 2019 at 10:17 AM 'Nathan Huckleberry' via Clang Built Linux <clang-built-linux@xxxxxxxxxxxxxxxx> wrote: > > Clang produces the following warning > > drivers/net/wireless/ti/wl18xx/main.c:1850:43: warning: unused variable > 'wl18xx_iface_ap_cl_limits' [-Wunused-const-variable] static const struct > ieee80211_iface_limit wl18xx_iface_ap_cl_limits[] = { ^ > drivers/net/wireless/ti/wl18xx/main.c:1869:43: warning: unused variable > 'wl18xx_iface_ap_go_limits' [-Wunused-const-variable] static const struct > ieee80211_iface_limit wl18xx_iface_ap_go_limits[] = { ^ > > The commit that added these variables never used them. Removing them. Previous thread, for context: https://groups.google.com/forum/#!topic/clang-built-linux/1Lu1GT9ic94 Looking at drivers/net/wireless/ti/wl18xx/main.c, there 4 globally declared `struct ieee80211_iface_limit` but as your patch notes, only 2 are used. The thing is, their uses are in a `struct ieee80211_iface_limit []`. Looking at $ git blame drivers/net/wireless/ti/wl18xx/main.c -L 1850 points to commit 7845af35e0de ("wlcore: add p2p device support") Adding Eliad and Arik to the thread; it's not clear to me what the these variables were supposed to do, but seeing as the code in question was already dead, this is no functional change from a user's perspective. With that in mind: Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> So I'd at least add the tag. Fixes: 7845af35e0de ("wlcore: add p2p device support") > --- a/drivers/net/wireless/ti/wl18xx/main.c > +++ b/drivers/net/wireless/ti/wl18xx/main.c > @@ -1847,44 +1847,6 @@ static const struct ieee80211_iface_limit wl18xx_iface_ap_limits[] = { > }, > }; > > -static const struct ieee80211_iface_limit wl18xx_iface_ap_cl_limits[] = { > - { > - .max = 1, > - .types = BIT(NL80211_IFTYPE_STATION), > - }, > - { > - .max = 1, > - .types = BIT(NL80211_IFTYPE_AP), > - }, > - { > - .max = 1, > - .types = BIT(NL80211_IFTYPE_P2P_CLIENT), > - }, > - { > - .max = 1, > - .types = BIT(NL80211_IFTYPE_P2P_DEVICE), > - }, > -}; > - > -static const struct ieee80211_iface_limit wl18xx_iface_ap_go_limits[] = { > - { > - .max = 1, > - .types = BIT(NL80211_IFTYPE_STATION), > - }, > - { > - .max = 1, > - .types = BIT(NL80211_IFTYPE_AP), > - }, > - { > - .max = 1, > - .types = BIT(NL80211_IFTYPE_P2P_GO), > - }, > - { > - .max = 1, > - .types = BIT(NL80211_IFTYPE_P2P_DEVICE), > - }, > -}; > - -- Thanks, ~Nick Desaulniers