> On Wed, Jun 12, 2019 at 02:28:48PM +0200, Lorenzo Bianconi wrote: [...] > > > > using sg buffers we can support bigger rx AMSDU size in the future without using > > huge buffers (e.g. we can try to use IEEE80211_MAX_MPDU_LEN_HT_7935 with > > mt76x2u) > > I think it would be simpler just to allocate 2 pages for 7935B . > We should avoid increasing buffer size to more than PAGE_SIZE for performance reasons. As suggested by Felix what about of setting buf_size to PAGE_SIZE for both sg and non-sg cases and for sg setting usb data size to SKB_WITH_OVERHEAD(q->buf_size) & (usb_endpoint_maxp() - 1); Regards, Lorenzo > Stanislaw
Attachment:
signature.asc
Description: PGP signature