Search Linux Wireless

Re: [PATCH 06/16] ath9k: Fix missing brace in branch on ath_chainmask_sel_logic()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-07-28 at 22:47 -0700, lrodriguez@xxxxxxxxxxx wrote:
> From: Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx>
> 
> diff --git a/drivers/net/wireless/ath9k/core.c b/drivers/net/wireless/ath9k/core.c
> index 47d4891..d9c7561 100644
> --- a/drivers/net/wireless/ath9k/core.c
> +++ b/drivers/net/wireless/ath9k/core.c
> @@ -508,9 +508,10 @@ int ath_chainmask_sel_logic(struct ath_softc *sc, struct ath_node *an)
>  	 * enabled/disabled setting
>  	 */
>  	if ((sc->sc_no_tx_3_chains == AH_FALSE) ||
> -	    (sc->sc_config.chainmask_sel == AH_FALSE))
> +	    (sc->sc_config.chainmask_sel == AH_FALSE)) {
>  		cm->cur_tx_mask = sc->sc_tx_chainmask;
>  		return cm->cur_tx_mask;
> +	}

I would prefer that all compile fixes are amended in the patches that
introduced them.  We should try to pass only correct patches upstream.
Bisection works best if one doesn't hit code that doesn't compile.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux