Hi, On Mon, Jun 10, 2019 at 1:56 AM Hunter, Adrian <adrian.hunter@xxxxxxxxx> wrote: > > > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > > @@ -16,6 +16,7 @@ > > #include <linux/mmc/sdio_ids.h> > > #include <linux/mmc/sdio_func.h> > > #include <linux/mmc/card.h> > > +#include <linux/mmc/core.h> > > SDIO function drivers should not really include linux/mmc/core.h > (Also don't know why linux/mmc/card.h is included) OK, so I guess you're requesting an extra level of "sdio_" wrappers for all the functions I need to call. I don't think the wrappers buy us a ton other than to abstract things a little bit and make it look prettier. :-) ...but certainly I can code that up if that's what everyone wants. Just to make sure, I looked in "drivers/net/wireless/" and I do see quite a few instances of "mmc_" functions being used. That doesn't mean all these instances are correct but it does appear to be commonplace. Selected examples: drivers/net/wireless/ath/ath10k/sdio.c: ret = mmc_hw_reset(ar_sdio->func->card->host); drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: mmc_set_data_timeout(md, func->card); mmc_wait_for_req(func->card->host, mr); drivers/net/wireless/marvell/mwifiex/sdio.c: mmc_hw_reset(func->card->host); drivers/net/wireless/rsi/rsi_91x_sdio.c: err = mmc_wait_for_cmd(host, &cmd, 3); ...anyway, I'll give it a few days and if nobody else chimes in then I'll assume you indeed want "sdio_" wrappers for things and I'll post a v4. If patch #1 happens to land in the meantime then I won't object. ;-) -Doug
