On 2019-05-14 11:18, Lorenzo Bianconi wrote:
> Fix following crash that occurs when the driver is processing rx packets
> while the device is not initialized yet
>
> $ rmmod mt7615e
> [ 67.210261] mt7615e 0000:01:00.0: Message -239 (seq 2) timeout
> $ modprobe mt7615e
> [ 72.406937] bus=0x1, slot = 0x0, irq=0x16
> [ 72.436590] CPU 0 Unable to handle kernel paging request at virtual address 00000004, epc == 8eec4240, ra == 8eec41e0
> [ 72.450291] mt7615e 0000:01:00.0: Firmware is not ready for download
> [ 72.457724] Oops[#1]:
> [ 72.470494] mt7615e: probe of 0000:01:00.0 failed with error -5
> [ 72.474829] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.14.114 #0
> [ 72.498702] task: 805769e0 task.stack: 80564000
> [ 72.507709] $ 0 : 00000000 00000001 00000000 00000001
> [ 72.518106] $ 4 : 8f704dbc 00000000 00000000 8f7046c0
> [ 72.528500] $ 8 : 00000024 8045e98c 81210008 11000000
> [ 72.538895] $12 : 8fc09f60 00000008 00000019 00000033
> [ 72.549289] $16 : 8f704d80 e00000ff 8f0c7800 3c182406
> [ 72.559684] $20 : 00000006 8ee615a0 4e000108 00000000
> [ 72.570078] $24 : 0000004c 8000cf94
> [ 72.580474] $28 : 80564000 8fc09e38 00000001 8eec41e0
> [ 72.590869] Hi : 00000001
> [ 72.596582] Lo : 00000000
> [ 72.602319] epc : 8eec4240 mt7615_mac_fill_rx+0xac/0x494 [mt7615e]
> [ 72.614953] ra : 8eec41e0 mt7615_mac_fill_rx+0x4c/0x494 [mt7615e]
> [ 72.627580] Status: 11008403 KERNEL EXL IE
> [ 72.635899] Cause : 40800008 (ExcCode 02)
> [ 72.643860] BadVA : 00000004
> [ 72.649573] PrId : 0001992f (MIPS 1004Kc)
> [ 72.657704] Modules linked in: mt7615e pppoe ppp_async pppox ppp_generic nf_conntrack_ipv6 mt76x2e mt76x2_common mt76x02_lib mt7603e mt76 mac80211 iptable_nat ipt_REJECT ipt_MASQUERADE cfg80211 xt_time xt_tcpudp xt_state xt_nat xt_mu]
> [ 72.792717] Process swapper/0 (pid: 0, threadinfo=80564000, task=805769e0, tls=00000000)
> [ 72.808799] Stack : 8f0c7800 00000800 8f0c7800 8032b874 00000000 40000000 8f704d80 8ee615a0
> [ 72.825428] 8dc88010 00000001 8ee615e0 8eec09b0 8dc88010 8032b914 8f3aee80 80567d20
> [ 72.842055] 00000000 8ee615e0 40000000 8f0c7800 00000108 8eec9944 00000000 00000000
> [ 72.858682] 80508f10 80510000 00000001 80567d20 8ee615a0 00000000 00000000 8ee61c00
> [ 72.875308] 8ee61c40 00000040 80610000 80580000 00000000 8ee615dc 8ee61a68 00000001
> [ 72.891936] ...
> [ 72.896793] Call Trace:
> [ 72.901649] [<8eec4240>] mt7615_mac_fill_rx+0xac/0x494 [mt7615e]
> [ 72.913602] [<8eec09b0>] mt7615_queue_rx_skb+0xe4/0x12c [mt7615e]
> [ 72.925734] [<8eec9944>] mt76_dma_cleanup+0x390/0x42c [mt76]
> [ 72.936988] Code: ae020018 8ea20004 24030001 <94420004> a602002a 8ea20004 90420000 14430003 a2020034
> [ 72.956390]
> [ 72.959676] ---[ end trace f176967739edb19f ]---
>
> Fixes: 04b8e65922f6 ("mt76: add mac80211 driver for MT7615 PCIe-based chipsets")
> Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
Applied, thanks.
- Felix
