On 5/31/2019 11:53 AM, Kalle Valo wrote: > External E-Mail > > > <Ajay.Kathat@xxxxxxxxxxxxx> writes: > >> Hi Kalle, >> >> On 5/23/2019 10:15 PM, Ajay.Kathat@xxxxxxxxxxxxx wrote: >>> Hi Kalle, >>> >>> On 5/23/2019 7:43 PM, Kalle Valo wrote: >>>> <Ajay.Kathat@xxxxxxxxxxxxx> writes: >>>> >>>>> Hi Kalle, >>>>> >>>>> On 3/21/2019 6:24 PM, Kalle Valo wrote: >>>>>> >>>>>> <Ajay.Kathat@xxxxxxxxxxxxx> writes: >>>>>> >>>>>>> Hi Kalle/Johannes, >>>>>>> >>>>>>> On 2/9/2019 12:42 PM, Ajay Kathat - I15481 wrote: >>>>>>>> From: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> >>>>>>>> >>>>>>>> This patch series is to review and move wilc1000 driver out of staging. >>>>>>>> Implemented the initial received review comments[1] and submitting the >>>>>>>> driver again. During this cleanup deleted around 3.3k lines of code. >>>>>>>> >>>>>>>> Below are the major items fixed in recent cleanup: >>>>>>>> - remove use of shadow buffer to keep scan result. >>>>>>>> - remove internal messaging flow to handle cfg80211_ops. >>>>>>>> - make use of cfg80211 provided API. >>>>>>>> - use structure for packing firmware commands. >>>>>>>> - make use of kernel provided API and macros. >>>>>>>> - remove unnecessary logs messages. >>>>>>>> >>>>>>>> Pending action item: >>>>>>>> - dynamically add/remove p2p interface. >>>>>>>> >>>>>>>> This item will take some time, we are planning to take it up after >>>>>>>> mainline. >>>>>>>> >>>>>>>> We hope it can be move out staging in v5.1. >>>>>>>> Please review and confirm if it is good to move out. >>>>>>> >>>>>>> Do you have any update for this series. Please provide your inputs for >>>>>>> next step. >>>>>> >>>>>> rtw88 is taking priority in the new drivers "queue" so I doubt I can >>>>>> take a look at this in the next few weeks. >>>>>> >>>>> >>>>> Is there any update for wilc1000 driver review. Please let me know your >>>>> inputs. >>>> >>>> So is the driver in good shape now? I really do not want to use a lot of >>>> time reviewing it just to find out that there's a lot of work to do. For >>>> example, has someone else reviewed it? >>>> >>> >>> The first series for complete driver review was submitted earlier [1]. >>> It was reviewed by Johannes and he looked into driver integration with >>> the cfg80211 stack part. We worked on the review comments and submitted >>> the changes to staging. >>> >>> We need further review to identify if there is any blocker to move to >>> mainline. >>> >>> [1]. https://www.spinics.net/lists/linux-wireless/msg177878.html >>> >> >> Just a gentle mail to check if wilc1000 driver is picked-up for review >> and what is the next step. > > Please be patient, getting a driver upstream is not a simple task. What > this driver needs now is reviews and people saying that the driver is > ready for upstream, I have not seen any of that yet. Maybe you could > submit a new version, hopefully that triggers people to review this? > Also I'll try to find time for review but, as usual, I'm really busy. > Thanks Kalle, I will wait for review comments and in the meantime I will send the patch update. Regards, Ajay
