> -----Original Message----- > From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] > Sent: Thursday, May 30, 2019 1:00 PM > To: Tony Chuang > Cc: Larry Finger; linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 01/11] rtw88: resolve order of tx power setting routines > > Tony Chuang <yhchuang@xxxxxxxxxxx> writes: > > >> -----Original Message----- > >> From: Larry Finger [mailto:larry.finger@xxxxxxxxx] On Behalf Of Larry > Finger > >> Sent: Wednesday, May 29, 2019 11:17 PM > >> To: Tony Chuang; kvalo@xxxxxxxxxxxxxx > >> Cc: linux-wireless@xxxxxxxxxxxxxxx > >> Subject: Re: [PATCH 01/11] rtw88: resolve order of tx power setting > routines > >> > >> On 5/29/19 2:54 AM, yhchuang@xxxxxxxxxxx wrote: > >> > From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > >> > > >> > Some functions that should be static are unnecessarily exposed, remove > >> > their declaration in header file phy.h. > >> > > >> > After resolving their declaration order, they can be declared as static. > >> > So this commit changes nothing except the order and marking them > static. > >> > > >> > Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > >> > >> This patch does not apply. Using quilt to see what is wrong, there are 6 > >> changes > >> that have already been applied. > >> > >> Larry > >> > > > > > > These patches are based on > > > > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/kvalo/wireless-dr > ivers > > branch master > > > > commit 6aca09771db4277a78853d6ac680d8d5f0d915e3 > > Author: YueHaibing <yuehaibing@xxxxxxxxxx> > > Date: Sat May 4 18:32:24 2019 +0800 > > > > rtw88: Make some symbols static > > > > > > It should apply, did I miss something? > > I keep the bar high and take to wireless-drivers only patches which fix > important, user visible problems. Everything else goes to > wireless-drivers-next. So you should use wireless-drivers-next as the > baseline for all regular patches. Hi, Kalle But this series has dependency with " rtw88: Make some symbols static" Or you can handle it > > -- > Kalle Valo > Yan-Hsuan