Search Linux Wireless

Re: Commit 741b4fbc44 (mac80211: fix TX sequence numbers) breaks rtl8187

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Herton Ronaldo Krzesinski <herton@xxxxxxxxxxxxxxx> writes:

> You are right, I was looking at wrong place, indeed the issue is on rtl8187. 
> The problem here is that mac80211 can call rtl8187_config while another 
> instance of it is still running, and on rtl8187_config this is a critical 
> section:
>

[...]

> My sequence of commands trigger this, so there are cases where it disables TX 
> loopback while there are another instance that can be still 
> inside ->set_chan, that's explain also why card stops to work. This section 
> should be lock protected or mac80211 ensure to not call local->ops->config 
> while another call is still running.

To tell you the truth, I don't know if ops->config() calls should be
serialized or not, but I have always used locking on the driver as a
precaution.

Johannes, can you comment on this, please?

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux