Lorenzo Bianconi <lorenzo@xxxxxxxxxx> writes: > Introduce a knob in mt7603 debugfs in order to enable/disable > edcca processing > > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user. > @@ -48,6 +77,7 @@ void mt7603_init_debugfs(struct mt7603_dev *dev) > if (!dir) > return; > > + debugfs_create_file("edcca", 0400, dir, dev, &fops_edcca); Why 0400 and not 0600? -- Kalle Valo