On Tue, Jul 29, 2008 at 04:53:15PM -0400, John W. Linville wrote:
> On Mon, Jul 21, 2008 at 09:18:21PM -0300, Henrique de Moraes Holschuh wrote:
> > Every time a new input device that is capable of one of the rfkill EV_SW events
> > (currently only SW_RFKILL_ALL) is connected to rfkill-input, we must check the
> > states of the input EV_SW switches and take action. Otherwise, we will ignore
> > the initial switch state.
> >
> > We also need to re-check the states of the EV_SW switches after a device that
> > was under an exclusive grab is released back to us, since we got no input
> > events from that device while it was grabbed.
> >
> > Signed-off-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> > Cc: Ivo van Doorn <IvDoorn@xxxxxxxxx>
> > Cc: Dmitry Torokhov <dtor@xxxxxxx>
>
> CC [M] net/rfkill/rfkill-input.o
> net/rfkill/rfkill-input.c: In function ‘rfkill_start’:
> net/rfkill/rfkill-input.c:201: warning: passing argument 2 of ‘constant_test_bit’ from incompatible pointer type
> net/rfkill/rfkill-input.c:201: warning: passing argument 2 of ‘variable_test_bit’ from incompatible pointer type
> net/rfkill/rfkill-input.c:202: warning: passing argument 2 of ‘constant_test_bit’ from incompatible pointer type
> net/rfkill/rfkill-input.c:202: warning: passing argument 2 of ‘variable_test_bit’ from incompatible pointer type
> net/rfkill/rfkill-input.c:203: warning: passing argument 2 of ‘constant_test_bit’ from incompatible pointer type
> net/rfkill/rfkill-input.c:203: warning: passing argument 2 of ‘variable_test_bit’ from incompatible pointer type
>
> Don't you need an index for those evbit, swbit, and sw arrays?
No, we just need to drop the &:
diff --git a/net/rfkill/rfkill-input.c b/net/rfkill/rfkill-input.c
index 827f178..e5b6955 100644
--- a/net/rfkill/rfkill-input.c
+++ b/net/rfkill/rfkill-input.c
@@ -198,10 +198,10 @@ static void rfkill_start(struct input_handle *handle)
* just fine (which event_lock will also avoid). */
spin_lock_irq(&handle->dev->event_lock);
- if (test_bit(EV_SW, &handle->dev->evbit)) {
- if (test_bit(SW_RFKILL_ALL, &handle->dev->swbit))
+ if (test_bit(EV_SW, handle->dev->evbit)) {
+ if (test_bit(SW_RFKILL_ALL, handle->dev->swbit))
rfkill_schedule_evsw_rfkillall(test_bit(SW_RFKILL_ALL,
- &handle->dev->sw));
+ handle->dev->sw));
/* add resync for further EV_SW events here */
}
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
