On Thu, 2019-05-09 at 16:11 +0800, Daniel Drake wrote: > On Fri, May 3, 2019 at 3:22 PM Chris Chiu <chiu@xxxxxxxxxxxx> wrote: > > Add wireless mode, signal strength level, and rate table index > > to tell the firmware that we need to adjust the tx rate bitmap > > accordingly. [] > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h [] > > +/*mlme related.*/ > > +enum wireless_mode { > > + WIRELESS_MODE_UNKNOWN = 0, > > + //Sub-Element > > Run these patches through checkpatch.pl, it'll have some suggestions > to bring the coding style in line, for example not using // style > comments. just fyi: checkpatch ignores // comments since 2016 (new in 2019: unless you add --ignore=c99_comment_tolerance) These are the relevant checkpatch commits: In 2016, commit dadf680de3c2 ("checkpatch: allow c99 style // comments") In 2019, commit 98005e8c743f ("checkpatch: allow reporting C99 style comments")