On Tue, Jul 29, 2008 at 10:19 PM, Kalle Valo <kalle.valo@xxxxxxxxx> wrote: > Tomas Winkler <tomasw@xxxxxxxxx> writes: > >> On Tue, Jul 29, 2008 at 9:53 AM, Johannes Berg >> <johannes@xxxxxxxxxxxxxxxx> wrote: >>> On Tue, 2008-07-29 at 00:21 -0300, Herton Ronaldo Krzesinski wrote: >>> >>>> [3] /sbin/iwconfig wlan0 power on >>> >>> I don't think turning on power management (yes, this command is >>> completely misnamed, it turns on power _management_ not the power, you >>> may want "txpower auto") does anything on this chip, does it? I had look through the code - mac80211 itself, the rtl8187b driver, and the client tool (iwconfig 29). The thing is, there is absolutely nothing in rtl8187b other than one reference to IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING, and in mac80211, as far as I understand, power saving should only has effect for driver in AP mode (as is IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING)? In any case, I tried removing IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING in the driver code, and also enabling CONFIG_MAC80211_VERBOSE_PS_DEBUG in net/mac80211/*.c - the former does not improve the situation, the latter seems to have no effect (i.e. none of the code with PS_DEBUG is invoked when using the driver in STA mode) - is that correct? >> >> iwconfig power on is not implemented by mac80211 yet. There was one >> patch posted that implements it. > > John has already applied Samuel's patch to wireless-testing: > > http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commitdiff;h=8f87dd7e540d455f8e7f11478133b85edc969c67 This is one of the two patches we have been talking about which breaks the rt8187b driver. (the other being the tx seq no one). > >> I wanted to expand it but wireless_tools 29 has a bug in parsing >> this command. It is fixed only in 30.pre6 which is usually not in >> distros. > > Could you be more specific, please? We have been using it for few > years now. Yes, I like to know what's the bug referring to also. I have looked at iwconfig 29 and it seems to be doing the right thing ("off" sets disable, "on" sets the value). Hin-Tak -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
