On Tue, Jul 29, 2008 at 11:55 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> On Tue, 29 Jul 2008 23:50:25 +0300 Tomas Winkler wrote:
>
>> On Tue, Jul 29, 2008 at 10:03 PM, Andreas Schwab <schwab@xxxxxxx> wrote:
>> > drivers/net/wireless/iwlwifi/iwl-led.c: In function 'iwl_led_brightness_set':
>> > drivers/net/wireless/iwlwifi/iwl-led.c:198: error: 'led_type_str' undeclared (first use in this function)
>> > drivers/net/wireless/iwlwifi/iwl-led.c:198: error: (Each undeclared identifier is reported only once
>> > drivers/net/wireless/iwlwifi/iwl-led.c:198: error: for each function it appears in.)
>> >
>> > Signed-off-by: Andreas Schwab <schwab@xxxxxxx>
>> > ---
>> > diff --git a/drivers/net/wireless/iwlwifi/iwl-led.c b/drivers/net/wireless/iwlwifi/iwl-led.c
>> > index 899d7a2..a58571c 100644
>> > --- a/drivers/net/wireless/iwlwifi/iwl-led.c
>> > +++ b/drivers/net/wireless/iwlwifi/iwl-led.c
>> > @@ -195,8 +195,10 @@ static void iwl_led_brightness_set(struct led_classdev *led_cdev,
>> > return;
>> >
>> >
>> > +#ifdef CONFIG_IWLWIFI_DEBUG
>> > IWL_DEBUG_LED("Led type = %s brightness = %d\n",
>> > led_type_str[led->type], brightness);
>> > +#endif
>> > switch (brightness) {
>> > case LED_FULL:
>> > if (led->type == IWL_LED_TRG_ASSOC)
>> >
>>
>> Thanks for your patch
>> But the fixes were already sent out a week ago or You can find them
>> on this mailing list.
>
> But the reason that we are seeing this (third IIRC) patch for this problem
> is that the patch needs to be merged somewhere..... :(
> other than the mailing list.
Definitely. John Linville was also on OLS I guess that's the reason
for delay in merge. I've even reposed this patches to LKML IRCC to
Andrew Morton's request
What more can I do. Maybe David Miller can somehow speed up the
process not sure.
But this is like 5th patch I've received to fix this starting to be a
bit annoying.
BTW 'Denis V. Lunev' is the author of the 3 patches that fixes this
http://marc.info/?l=linux-wireless&m=121642949226032&w=2
http://marc.info/?l=linux-wireless&m=121636411821968&w=2
http://marc.info/?l=linux-wireless&m=121629329109400&w=2
Tomas.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
