> Subject: Re: [PATCH 1/6] rtw88: add license for Makefile > > <yhchuang@xxxxxxxxxxx> writes: > > > From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > > > > Add missing license for Makefile > > > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > > --- > > drivers/net/wireless/realtek/rtw88/Makefile | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/wireless/realtek/rtw88/Makefile > b/drivers/net/wireless/realtek/rtw88/Makefile > > index da5e36e..74cd066 100644 > > --- a/drivers/net/wireless/realtek/rtw88/Makefile > > +++ b/drivers/net/wireless/realtek/rtw88/Makefile > > @@ -1,3 +1,5 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > Other files in the driver are "GPL-2.0 OR BSD-3-Clause", why not > Makefile? I prefer that the whole driver has the same license, keeps > things simple. > > -- > Kalle Valo > You are right, different license is strange. Will add it in v2, thanks. Yan-Hsuan