On Wed, May 01, 2019 at 10:09:34AM +0300, Kalle Valo wrote: > Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> writes: > > > On Tue, Apr 30, 2019 at 07:47:13PM +0300, Kalle Valo wrote: > >> Stanislaw Gruszka <sgruszka@xxxxxxxxxx> writes: > >> > >> > On Tue, Apr 30, 2019 at 03:40:02PM +0300, Kalle Valo wrote: > >> >> > From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > >> >> > > >> >> > This is a new mac80211 driver for Realtek 802.11ac wireless network chips. > >> >> > rtw88 now supports RTL8822BE/RTL8822CE now, with basic station mode > >> >> > functionalities. The firmware for both can be found at linux-firmware. > >> >> > >> >> This looks very good now. I did a quick review of the driver and had few > >> >> netpicks but nothing really blocking applying this. So I have now > >> >> combined these patches into one big patch and pushed it to the pending > >> >> branch: > >> >> > >> >> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?h=pending&id=284d1e4e3311cfe67c1c57ccc275ff0f5666aeea > >> >> > >> >> I appreciate if people could do a quick check and make sure that I > >> >> didn't do anything stupid when folding the patches. > >> > > >> > I've build pending branch and done few quick tests on Realtek > >> > 8822CE device. Everything works ok. > >> > >> Thanks so much for this, I now feel much more comfortable merging it :) > >> > >> So this is manually applied to wireless-drivers-next: > >> > >> e3037485c68e rtw88: new Realtek 802.11ac driver > >> > >> And it should be in tomorrow's linux-next build, let's see what kind of > >> reports we get. Greg, feel free to delete the corresponding staging > >> driver from your tree (I forgot the name of the driver already). > > > > I'll be glad to do so if someone also tells me what the driver's name is > > as well, I don't remember either :) > > I checked it now, the directory is drivers/staging/rtlwifi. Here's the > commit adding the upstream driver, in case you need that in the commit > log: > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=e3037485c68ec1a299ff41160d8fedbd4abc29b9 Thanks for this, now dropped from my tree (with the exception of 2 .h files which a different driver used, and I'll clean that up as well with a later patch.) Note, the diffstat involved here shows that a "proper" Linux driver that is merged into the kernel tree follows the rule-of-thumb that I have consistently seen over time. An in-tree driver that has been reviewed properly is 33% of the size of an "out of tree" driver. It's always nice to see users benefit from properly developed drivers like this. thanks, greg k-h
