<yhchuang@xxxxxxxxxxx> writes: > From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > > main files for Realtek 802.11ac wireless network chips > > Reviewed-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> [...] > +static inline bool rtw_flag_check(struct rtw_dev *rtwdev, enum rtw_flags flag) > +{ > + return test_bit(flag, rtwdev->flags); > +} > + > +static inline void rtw_flag_clear(struct rtw_dev *rtwdev, enum rtw_flags flag) > +{ > + clear_bit(flag, rtwdev->flags); > +} > + > +static inline void rtw_flag_set(struct rtw_dev *rtwdev, enum rtw_flags flag) > +{ > + set_bit(flag, rtwdev->flags); > +} In upstream we don't usually like these kind of abstractions, they just hide what the code does. -- Kalle Valo