Search Linux Wireless

Re: [PATCH v2 5/5] mt76: mt7603: enable/disable pre_tbtt_tasklet in mt7603_set_channel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
Subject: Re: [PATCH v2 5/5] mt76: mt7603: enable/disable pre_tbtt_tasklet in mt7603_set_channel
From: Felix Fietkau <nbd@xxxxxxxx>
Date: Tue, 30 Apr 2019 11:34:36 +0200
Cc: lorenzo.bianconi@xxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, sgruszka@xxxxxxxxxx
In-reply-to: <ad6f286f30e8d9080320164a5551c2ee37bd6a95.1556525110.git.lorenzo@kernel.org>
Openpgp: preference=signencrypt
References: <cover.1556525110.git.lorenzo@kernel.org> <ad6f286f30e8d9080320164a5551c2ee37bd6a95.1556525110.git.lorenzo@kernel.org>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 2019-04-29 10:13, Lorenzo Bianconi wrote:
> Disable pre_tbtt_tasklet tasklet before setting the operating channel.
> Enable/disable beacon_timer in mt7603_set_channel
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
This doesn't seem right to me - I don't think we should send beacons
while off-channel.

- Felix

Follow-Ups:
- Re: [PATCH v2 5/5] mt76: mt7603: enable/disable pre_tbtt_tasklet in mt7603_set_channel
  - From: Lorenzo Bianconi

References:
- [PATCH v2 0/5] mt76: move common beacon code in mt76 module
  - From: Lorenzo Bianconi
- [PATCH v2 5/5] mt76: mt7603: enable/disable pre_tbtt_tasklet in mt7603_set_channel
  - From: Lorenzo Bianconi

Prev by Date: Re: [PATCH v2] mt76: mt7615: add TX/RX antenna pattern capabilities
Next by Date: Re: [PATCH] ath10k: add peer id check in ath10k_peer_find_by_id
Previous by thread: [PATCH v2 5/5] mt76: mt7603: enable/disable pre_tbtt_tasklet in mt7603_set_channel
Next by thread: Re: [PATCH v2 5/5] mt76: mt7603: enable/disable pre_tbtt_tasklet in mt7603_set_channel
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]