Search Linux Wireless

Re: [PATCH V2 1/3] mac80211: allow turning TWT responder support on and off via netlink

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 26/04/2019 21:51, Johannes Berg wrote:
On Fri, 2019-04-26 at 21:50 +0200, John Crispin wrote:
On 26/04/2019 11:41, John Crispin wrote:
@@ -6105,6 +6106,7 @@ static int nl80211_set_bss(struct sk_buff *skb, struct genl_info *info)
   	params.ht_opmode = -1;
   	params.p2p_ctwindow = -1;
   	params.p2p_opp_ps = -1;
+	params.twt_responder = -1;
if (info->attrs[NL80211_ATTR_BSS_CTS_PROT])
   		params.use_cts_prot =
@@ -6149,6 +6151,10 @@ static int nl80211_set_bss(struct sk_buff *skb, struct genl_info *info)
   			return -EINVAL;
   	}
+ if (info->attrs[NL80211_ATTR_TWT_RESPONDER])
+		params.twt_responder =
+		    nla_get_u8(info->attrs[NL80211_ATTR_TWT_RESPONDER]);
+
   	if (!rdev->ops->change_bss)
   		return -EOPNOTSUPP;
Hi,

this should probably be moved to nl80211_start_ap() instead of
nl80211_set_bss() as we probably dont want to change this at runtime ?
I have no idea, can we change it at runtime? Is it a capability or an
operational state?

johannes

its a capability, only the twt_required bit is an operational state. so I shall send a V3 moving it to start_ap() :-)

    John




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux