Search Linux Wireless

Re: [PATCH] mac80211: partially fix skb->cb use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2008-07-29 at 13:42 +0200, Luis Carlos Cobo wrote:

> One of the options I was thinking about when implemented that was to do
> the forwarding in what was once equivalent to ieee80211_data_to_8023()
> function. Then we do not have to do 802.11->802.3->802.11 series of
> conversions, and we would send the frames to be forwarded directly to
> the master device, speeding up things a bit.

That sounds sane to me, then you don't need the cb at all, do you? Can
just send it to the master dev with skb->do_not_encrypt set, right?

In fact, looking at the code, there seems to be a bug with promisc, are
you sure it's allowed to netif_rx/dev_queue_xmit the same frame?

> I think the most elegant solution would be to add a rx handler to be run
> before ieee80211_data_to_8023() dealing with forwarding and sending
> frames directly to the master device. 

That sounds reasonable.

> Would it make sense to deal there
> too with the forwarding for APs and VLAN interfaces done in
> ieee80211_deliver_skb?

I don't think so. AP mode doesn't really forward MPDUs but MSDUs, which
should make a difference when encryption is enabled.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux