Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
> The commit fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent
> adapter status variables") had a fairly straightforward bug in it. It
> contained this bit of diff:
>
> - if (!adapter->is_suspended) {
> + if (test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) {
>
> As you can see the patch missed the "!" when converting to the atomic
> bitops. This meant that the resume hasn't done anything at all since
> that commit landed and suspend/resume for mwifiex SDIO cards has been
> totally broken.
>
> After fixing this mwifiex suspend/resume appears to work again, at
> least with the simple testing I've done.
>
> Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent adapter status variables")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>
Patch applied to wireless-drivers.git, thanks.
b82d6c1f8f82 mwifiex: Make resume actually do something useful again on SDIO cards
--
https://patchwork.kernel.org/patch/10884883/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
