On 4/16/2019 10:37 AM, Johannes Berg wrote:
On Tue, 2019-04-16 at 16:36 +0800, Herbert Xu wrote:
On Tue, Apr 16, 2019 at 10:04:24AM +0200, Arend Van Spriel wrote:
I was just writing up an email clarifying my question. But let me summarize
this email thread. The patch from Felix adds this flag in mac80211 for
drivers that indicate to support pulling packets from the internal TXQ in
mac80211. I found it is deprecated, but as Felix mentioned it is used in
various parts of the network subsystem, ie. batman-adv, bridge, vlan, tunnel
implementations. So its use seems to be restricted rather than deprecated.
Given your response above I guess my question would be to get details about
what you call "proper design" as I think you are saying with that it is not
needed, right?
Essentially the only time it would be OK to use LLTX in its current
form is if you have no TX queue/congestion feedback which is clearly
not the case with wireless drivers.
It is true because we have an entire buffering layer in mac80211 (in
this case at least) and never push back to the stack.
Ok, so the crux is the "never push back to the stack" part? Well, the
internal TXQ and how that is used is obviously enabling that ;-)
Regards,
Arend
