> -----Original Message----- > From: Petr Mladek <pmladek@xxxxxxxx> > Sent: Friday, 12 April 2019 11:48 PM > To: Alastair D'Silva <alastair@xxxxxxxxxxx> > Cc: alastair@xxxxxxxxxxx; Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>; Joonas > Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>; Rodrigo Vivi > <rodrigo.vivi@xxxxxxxxx>; David Airlie <airlied@xxxxxxxx>; Daniel Vetter > <daniel@xxxxxxxx>; Karsten Keil <isdn@xxxxxxxxxxxxxx>; Jassi Brar > <jassisinghbrar@xxxxxxxxx>; Tom Lendacky <thomas.lendacky@xxxxxxx>; > David S. Miller <davem@xxxxxxxxxxxxx>; Jose Abreu > <Jose.Abreu@xxxxxxxxxxxx>; Kalle Valo <kvalo@xxxxxxxxxxxxxx>; > Stanislaw Gruszka <sgruszka@xxxxxxxxxx>; Benson Leung > <bleung@xxxxxxxxxxxx>; Enric Balletbo i Serra > <enric.balletbo@xxxxxxxxxxxxx>; James E.J. Bottomley > <jejb@xxxxxxxxxxxxx>; Martin K. Petersen <martin.petersen@xxxxxxxxxx>; > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Alexander Viro > <viro@xxxxxxxxxxxxxxxxxx>; Sergey Senozhatsky > <sergey.senozhatsky@xxxxxxxxx>; Steven Rostedt <rostedt@xxxxxxxxxxx>; > Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>; intel- > gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; > ath10k@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; linux- > scsi@xxxxxxxxxxxxxxx; linux-fbdev@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxx; linux-fsdevel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line > > On Wed 2019-04-10 13:17:17, Alastair D'Silva wrote: > > From: Alastair D'Silva <alastair@xxxxxxxxxxx> > > > > With modern high resolution screens, we can display more data, which > > makes life a bit easier when debugging. > > I have quite some doubts about this feature. > > We are talking about more than 256 characters per-line. I wonder if such a > long line is really easier to read for a human. It's basically 2 separate panes of information side by side, the hexdump and the ASCII version. I'm using this myself when dealing with the pmem labels, and it works quite nicely. > > I am not expert but there is a reason why the standard is 80 characters per- > line. I guess that anything above 100 characters is questionable. > https://en.wikipedia.org/wiki/Line_length > somehow confirms that. > > Second, if we take 8 pixels per-character. Then we need > 2048 to show the 256 characters. It is more than HD. > IMHO, there is still huge number of people that even do not have HD display, > especially on a notebook. The intent is to make debugging easier when dealing with large chunks of binary data. I don't expect end users to see this output. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: alastair@xxxxxxxxxxx blog: http://alastair.d-silva.org Twitter: @EvilDeece
