Search Linux Wireless

Re: [PATCHv3 2/2] mac80211: Implement API to configure station specific rssi threshold

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tamizh,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mac80211-next/master]
[also build test WARNING on next-20190412]
[cannot apply to v5.1-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Tamizh-chelvam/cfg80211-Add-support-to-configure-station-specific-RSSI-threshold-for-AP-mode/20190412-225220
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'


sparse warnings: (new ones prefixed by >>)

>> net/mac80211/cfg.c:3947:17: sparse: incompatible types in comparison expression (different address spaces)
--
>> net/mac80211/rx.c:1735:13: sparse: context imbalance in 'ieee80211_sta_rx_signal_thold_check' - wrong count at exit

vim +3947 net/mac80211/cfg.c

  3940	
  3941	void sta_mon_rssi_config_free(struct sta_info *sta)
  3942	{
  3943		struct sta_mon_rssi_config *old_rssi_config;
  3944	
  3945		if (sta->rssi_config) {
  3946			old_rssi_config = sta->rssi_config;
> 3947			RCU_INIT_POINTER(sta->rssi_config, NULL);
  3948			kfree_rcu(old_rssi_config, rcu_head);
  3949		}
  3950	}
  3951	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux