On Fri, 2019-03-15 at 18:36 +0200, Luca Coelho wrote: > From: Luca Coelho <luciano.coelho@xxxxxxxxx> > > Make sure the length of the ciphers we are copying never exceeds the > space we have for storing them. There is no risk of overcopying at > the moment, because we check n_params before, but this makes this > function safer in case someone changes something in the future. I don't think this makes sense. If anything, we should pass extack to mac80211_hwsim_new_radio() and do the entire validation there, but doing the same thing twice in two places just because of static checkers is useless. johannes