Search Linux Wireless

Re: [PATCHv2 1/2] cfg80211: Add support to configure station specific RSSI threshold for AP mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2019-02-05 at 15:36 +0530, Tamizh chelvam wrote:
> 
> +	[NL80211_ATTR_CQM] = {
> +		.type = NLA_NESTED,
> +		.validation_data = nl80211_attr_cqm_policy,
> +	 },

This is wrong, you need to use NLA_POLICY_NESTED().

> +	[NL80211_ATTR_STA_MON_FIXED_THOLD] = { .type = NLA_U8 },

Please use NLA_POLICY_RANGE(NLA_U8, 0, 1).

Also, I'm not sure I really understand the documentation for this value.

>  	/* Check all values negative and sorted */
> -	for (i = 0; i < n_thresholds; i++) {
> +	for (i = 0; i < n_tholds; i++) {

Why rename the perfectly fine variable to some abbreviation?

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux