2008/7/28 Pavel Roskin <proski@xxxxxxx>: > On Mon, 2008-07-28 at 16:04 +0300, Nick Kossifidis wrote: > >> > Please amend this to the patch 1 to not break bisectability. >> >> I see your point but this series is meant to be applied as a whole, i >> didn't notice this bug until i tested the code with debugging enabled >> (which is off by default), that's why it's "last minute fix". Is it >> really that much needed to repost the first patch ? I mean the patch >> series works and doesn't introduce any problems... > > The reason is that git-bisect divides the number of commits in half and > checks out the middle commit. That commit make be a broken one. > Hitting one bug while hunting another is not nice. > > Besides, nobody wants to apply a known bad patch. > > It would be great if you repost fixed patches. If you are not using > stgit, please try it. I would make it easy to return to older patches > and change them. "stg edit -d" even allows editing the patch. > > -- > Regards, > Pavel Roskin > O.K. then i'll repost the first patch asap (i'm still in Ottawa :P)... -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html