Re: [PATCH] iwlegacy: remove redundant assignment to *res

[Mukesh Ojha <mojha@xxxxxxxxxxxxxx>]

On 3/31/2019 1:44 AM, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently 1 is being assigned to *res and then it is immediately
> updated with the computed result.  The first assignment is
> redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Reviewed-by: Mukesh Ojha <mojha@xxxxxxxxxxxxxx>

Cheers,
-Mukesh

> ---
>   drivers/net/wireless/intel/iwlegacy/4965.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlegacy/4965.c b/drivers/net/wireless/intel/iwlegacy/4965.c
> index ce4144a89217..a20b6c885047 100644
> --- a/drivers/net/wireless/intel/iwlegacy/4965.c
> +++ b/drivers/net/wireless/intel/iwlegacy/4965.c
> @@ -577,7 +577,6 @@ il4965_math_div_round(s32 num, s32 denom, s32 * res)
>   		sign = -sign;
>   		denom = -denom;
>   	}
> -	*res = 1;
>   	*res = ((num * 2 + denom) / (denom * 2)) * sign;
>   
>   	return 1;