Hi, On Wed, Mar 13, 2019 at 12:13:49PM +0800, yhchuang@xxxxxxxxxxx wrote: > From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > > This is a new mac80211 driver for Realtek 802.11ac wireless network chips. > rtw88 now supports RTL8822BE/RTL8822CE now, with basic station mode > functionalities. The firmware for both can be found at linux-firmware. > > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git > For RTL8822BE: rtw88/rtw8822b_fw.bin > For RTL8822CE: rtw88/rtw8822c_fw.bin > Potential problems: > * TRX statictics misleading, as we are not reporting status correctly, > or say, not reporting for "every" packet. By the way, I see earlier RFC versions had similar comments/questions from Stanislaw and Kalle that I had too. So at least Kalle didn't have a great answer either on what to do with hardware where it is inefficient to get ACK reports for everything :D But least you did add a little bit of comments this time, and fixed up some of the reporting. ... > v5 ... > - use macro instead of ugly struct layout with #ifdef __LITTLE_ENDIAN BTW, you technically could still use a struct there if you'd like, but removing the bitfield / __LITTLE_ENDIAN handling was nice, thank you. > - simplify efuse logical map parsing function Much better, thank you! ... > - enable DMA sync to avoid pci bus timeout ... > v8 > > - add prefix "rtw_" to *_rates and corresponding *_sizes, otherwise > the extern will confuse the linker there are multiple definitions > with brcmsmac driver I can't say I've closely reviewed every bit of this driver, but I did tackle significant portions of it. All my comments have been addressed, apart from one relatively insignificant piece that I re-commented on this version. So: Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx> I also gave 8822CE some moderate testing, and while I'm sure it's not perfect, it's at least stable, and it's in much better than when I tested approximately v2 (as Tony has rolled in a lot of fixes since then): Tested-by: Brian Norris <briannorris@xxxxxxxxxxxx>
