> On Mar 12, 2019, at 2:56 AM, Kangjie Lu <kjlu@xxxxxxx> wrote:
>
> In case alloc_workqueue fails, the fix reports the error and
> returns to avoid NULL pointer dereference.
>
> Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>
> ---
> drivers/net/wireless/realtek/rtlwifi/base.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index 217d2a7a43c7..ac746c322554 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -448,6 +448,11 @@ static void _rtl_init_deferred_work(struct ieee80211_hw *hw)
> /* <2> work queue */
> rtlpriv->works.hw = hw;
> rtlpriv->works.rtl_wq = alloc_workqueue("%s", 0, 0, rtlpriv->cfg->name);
> + if (unlikely(!rtlpriv->works.rtl_wq)) {
> + pr_err("Failed to allocate work queue\n");
> + return;
> + }
> +
Can someone review the patch?
Thanks.
> INIT_DELAYED_WORK(&rtlpriv->works.watchdog_wq,
> (void *)rtl_watchdog_wq_callback);
> INIT_DELAYED_WORK(&rtlpriv->works.ips_nic_off_wq,
> --
> 2.17.1
>
