On Fri, Mar 22, 2019 at 11:10:40AM +0100, Lorenzo Bianconi wrote: > > We do not need to pass len and sglen to the function. > > Additionally pass gfp to control allocation context. > > > > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > > --- > > drivers/net/wireless/mediatek/mt76/usb.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c > > index 3f21599d52de..56e7a2ca8930 100644 > > --- a/drivers/net/wireless/mediatek/mt76/usb.c > > +++ b/drivers/net/wireless/mediatek/mt76/usb.c > > @@ -285,11 +285,13 @@ mt76u_set_endpoints(struct usb_interface *intf, > > } > > > > static int > > -mt76u_fill_rx_sg(struct mt76_dev *dev, struct mt76u_buf *buf, > > - int nsgs, int len, int sglen) > > +mt76u_fill_rx_sg(struct mt76_dev *dev, struct mt76u_buf *buf, int nsgs, > > + gfp_t gfp) > > { > > struct mt76_queue *q = &dev->q_rx[MT_RXQ_MAIN]; > > + int sglen = SKB_WITH_OVERHEAD(q->buf_size); > > struct urb *urb = buf->urb; > > + > > please drop newline here Not sure where it came from, but is already removed on patch 8. Stanislaw