Hello Kalle,
> >> > Fix creation of debugfs entries for qtnfmac wireless card: use separate
> >> > directories for different wireless cards. This commit enables support
> >> > for multiple qtnfmac wireless cards on the same PCIe host.
> >> >
> >> > Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxxx>
> >> > ---
> >> > drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c | 6 +++++-
> >> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c
> >> > index b561b75e4433..56fc6d49c121 100644
> >> > --- a/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c
> >> > +++ b/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c
> >> > @@ -130,6 +130,8 @@ static int qtnf_dbg_shm_stats(struct seq_file *s, void *data)
> >> >
> >> > int qtnf_pcie_fw_boot_done(struct qtnf_bus *bus)
> >> > {
> >> > + struct qtnf_pcie_bus_priv *priv = get_bus_priv(bus);
> >> > + char card_id[64];
> >> > int ret;
> >> >
> >> > bus->fw_state = QTNF_FW_STATE_BOOT_DONE;
> >> > @@ -137,7 +139,9 @@ int qtnf_pcie_fw_boot_done(struct qtnf_bus *bus)
> >> > if (ret) {
> >> > pr_err("failed to attach core\n");
> >> > } else {
> >> > - qtnf_debugfs_init(bus, DRV_NAME);
> >> > + snprintf(card_id, sizeof(card_id), "%s:%s",
> >> > + DRV_NAME, pci_name(priv->pdev));
> >>
> >> Can you give an example for the path?
> >>
> >
> > For instance: /sys/kernel/debug/qtnfmac_pcie:0000:01:00.0
>
> TBH not really fond of that. What about
> "/sys/kernel/debug/qtnfmac/pcie:0000:01:00.0"? IIRC iwlwifi used
> something like that.
>
> And please add an example path to the commit log.
Ok, will be fixed and resubmitted in v2.
Or, alternatively, if the other patches are ok for you,
feel free to drop the questionable ones and apply all
the others. I will rework the rejected pieces and
resubmit them, adding more pending fixes.
Regards,
Sergey
