On 2019-03-17 22:59, Toke Høiland-Jørgensen wrote: > Felix Fietkau <nbd@xxxxxxxx> writes: >> I've looked at ath9k (the only user at the moment), and it seems to call >> the function in that way already: at PS wake or tx status time if it has >> frames in its internal retry queue. >> While it does not match the current documented behavior for that >> function, it nicely fits ath9k's currently unfulfilled expectations ;) > > Heh, fair point :) I noticed another issue: after the migration to the mac80211 txq scheduling code, ath9k does not handle stations going to powersave properly anymore. mac80211 keeps returning txqs for stations that have gone to sleep and ath9k will send out frames for them. We could deal with this in the driver and simply not return queues for stations in PS mode, or mac80211 could actively cancel them once a station enters PS mode. What do you prefer? - Felix
