On Sat, 2019-02-16 at 15:45 -0800, thomas pedersen wrote: > Hello, > > I'm working on defining new channels for S1G PHYs in mac80211. These > are in the 900MHz range and center frequency for the 1MHz channels are > on a half MHz, while the existing channel definitions are in units of > MHz. Yay... :) > In order to support the new channels we could change the internal > center frequency units to KHz and extend the nl80211 API so > NL80211_FREQUENCY_ATTR_FREQ and NL80211_ATTR_WIPHY_FREQ get _KHZ > variants while renaming the original attributes to _MHZ to reflect the > units. The nl80211 API seems straightforward, yeah. > From looking at the code it looks like this should be fairly > straightforward, if involving a lot of changes since the driver > declarations would have to change too. Am I missing something > obviously wrong, or does this sound reasonable? I'm not sure I agree about all the driver changes being straightforward. In theory yes, but ... ;-) I guess you'd define a new band (NL80211_BAND_S1G or something?), so perhaps there's a way we can get away with doing it only on that band? OTOH, I guess if you change center_freq1 to center_freq1_khz or something then you compile-fail everywhere ... johanne
