Hi Rakesh, Thank you for the patch! Yet something to improve: [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on next-20190306] [cannot apply to v5.0] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rakesh-Pillai/Fix-tx-stats-inconsistencies/20190312-061743 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 8.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.2.0 make.cross ARCH=xtensa All errors (new ones prefixed by >>): drivers/net//wireless/ath/ath10k/htt_rx.c: In function 'ath10k_accumulate_per_peer_tx_stats': >> drivers/net//wireless/ath/ath10k/htt_rx.c:2934:14: error: implicit declaration of function 'ath10k_get_bw'; did you mean 'ath10k_get_tid'? [-Werror=implicit-function-declaration] rtable_bw = ath10k_get_bw(&ar->hw_params, pstats->flags); ^~~~~~~~~~~~~ ath10k_get_tid cc1: some warnings being treated as errors vim +2934 drivers/net//wireless/ath/ath10k/htt_rx.c 2914 2915 static void 2916 ath10k_accumulate_per_peer_tx_stats(struct ath10k *ar, 2917 struct ath10k_sta *arsta, 2918 struct ath10k_per_peer_tx_stats *pstats, 2919 s8 legacy_rate_idx) 2920 { 2921 struct rate_info *txrate = &arsta->txrate; 2922 struct ath10k_htt_tx_stats *tx_stats; 2923 int idx, ht_idx, gi, mcs, bw, nss; 2924 unsigned long flags; 2925 int rtable_bw; 2926 2927 if (!arsta->tx_stats) 2928 return; 2929 2930 tx_stats = arsta->tx_stats; 2931 flags = txrate->flags; 2932 gi = test_bit(ATH10K_RATE_INFO_FLAGS_SGI_BIT, &flags); 2933 mcs = ATH10K_HW_MCS_RATE(pstats->ratecode); > 2934 rtable_bw = ath10k_get_bw(&ar->hw_params, pstats->flags); 2935 bw = txrate->bw; 2936 nss = txrate->nss; 2937 ht_idx = mcs + (nss - 1) * 8; 2938 idx = mcs * 8 + 8 * 10 * (nss - 1); 2939 idx += rtable_bw * 2 + gi; 2940 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
