On Mon, Mar 11, 2019 at 01:35:23PM +0100, Lorenzo Bianconi wrote: > +static inline int mt76_insert_hdr_pad(struct sk_buff *skb) > +{ > + int len = ieee80211_get_hdrlen_from_skb(skb); > + > + if (len % 4 == 0) > + return 0; > + > + skb_push(skb, 2); > + memmove(skb->data, skb->data + 2, len); > + > + skb->data[len] = 0; > + skb->data[len + 1] = 0; > + return 2; > +} <snip> > @@ -165,7 +165,7 @@ int mt76x02_tx_prepare_skb(struct mt76_dev *mdev, void *txwi_ptr, > pid = mt76_tx_status_skb_add(mdev, wcid, skb); > txwi->pktid = pid; > > - ret = mt76x02_insert_hdr_pad(skb); > + ret = mt76_insert_hdr_pad(skb); > if (ret < 0) > return ret; Since you modify this you can make mt76_inser_hdr_pad() return void since we do not return error any longer. Stanislaw