On Mon, Mar 11, 2019 at 03:14:38PM +0200, Kalle Valo wrote: > Stanislaw Gruszka <sgruszka@xxxxxxxxxx> writes: > > >> +#define RA_MASK_VHT_RATES_1SS (0x3ff000 << 0) > >> +#define RA_MASK_VHT_RATES_2SS (0x3ff000 << 10) > >> +#define RA_MASK_VHT_RATES_3SS (0x3ff000 << 20) > > > > Result will not fit in 32 bit, ULL marker should be added. > > I haven't checked how these are used but IMHO using GENMASK() would be > so much better. GENMASK_ULL() in this case :-) Stanislaw
