On Sat, Mar 09, 2019 at 09:48:17PM +0800, yhchuang@xxxxxxxxxxx wrote: > + rtw_write32s_mask(rtwdev, REG_RFESEL8, MASKBYTE1, 0x57); Using of 0xff00 would more readable for average developer than MASKBYTE1 IMHO all of those MASK* defines should be removed and replaced by hex numbers or GENMASK() makro for non-standard masks like 0x3fe0 . > + rtw_write32_mask(rtwdev, REG_CCASEL, MASKDWORD, reg82c); MASKDWORD is 0xffffffff (all bits of 32 bit word), rtw_write32_mask() can be just replaced by rtw_write32(). Stanislaw
