On USB we do not have available PSD queue. Using standard AC queues is unreliable for sending PS buffered frames, stations can go sleep again before frames are sent. Only reliable way I could find to sent broadcast PS buffered frames is put them into beacon data registers, then frames are sent just after proper beacon. HW do the work when we encrypt the frames in software. I tested functionality used arping to iwlwifi station that do aggressive PS, it works like this: # arping -c 1 -I wlan0 192.168.9.110 ARPING 192.168.9.110 from 192.168.9.1 wlan0 Unicast reply from 192.168.9.110 [4C:34:88:5E:76:D5] 324.885ms Sent 1 probes (1 broadcast(s)) Otherwise arping fails: # arping -c 1 -I wlan0 192.168.9.110 ARPING 192.168.9.110 from 192.168.1.148 wlan0 Sent 1 probes (1 broadcast(s)) Received 0 response(s) I'm not sure how to test mt76_release_buffered_frames functionality. Also I have not tested on MMIO hardware, but for this only code movement was done so things should not break. RFC -> v1: - do no remove set_tim - add tbtt_start/stop for mt76x2u - rebase on top of: [PATCH 0/5] introduce mt76_sw_queue data structure https://lore.kernel.org/linux-wireless/cover.1551533068.git.lorenzo@xxxxxxxxxx/ Stanislaw Gruszka (11): mt76x02: introduce mt76x02_beacon.c mt76x02: add hrtimer for pre TBTT for USB mt76x02: introduce beacon_ops mt76x02u: implement beacon_ops mt76x02: generalize some mmio beaconing functions mt76x02u: add sta_ps mt76x02: disable HW encryption for group frames mt76x02u: implement pre TBTT work for USB mt76x02u: add mt76_release_buffered_frames mt76: unify set_tim mt76x02: enable AP mode for USB drivers/net/wireless/mediatek/mt76/Makefile | 2 +- drivers/net/wireless/mediatek/mt76/mac80211.c | 7 + drivers/net/wireless/mediatek/mt76/mt76.h | 2 + .../net/wireless/mediatek/mt76/mt7603/main.c | 8 +- .../net/wireless/mediatek/mt76/mt76x0/init.c | 1 - .../net/wireless/mediatek/mt76/mt76x0/main.c | 8 +- .../net/wireless/mediatek/mt76/mt76x0/pci.c | 11 +- .../net/wireless/mediatek/mt76/mt76x0/usb.c | 10 +- drivers/net/wireless/mediatek/mt76/mt76x02.h | 22 ++ .../wireless/mediatek/mt76/mt76x02_beacon.c | 308 ++++++++++++++++++ .../net/wireless/mediatek/mt76/mt76x02_mac.c | 138 -------- .../net/wireless/mediatek/mt76/mt76x02_mmio.c | 131 +++----- .../net/wireless/mediatek/mt76/mt76x02_regs.h | 5 +- .../net/wireless/mediatek/mt76/mt76x02_usb.h | 2 + .../wireless/mediatek/mt76/mt76x02_usb_core.c | 153 +++++++++ .../net/wireless/mediatek/mt76/mt76x02_util.c | 77 +---- .../wireless/mediatek/mt76/mt76x2/pci_init.c | 2 +- .../wireless/mediatek/mt76/mt76x2/pci_main.c | 8 +- .../net/wireless/mediatek/mt76/mt76x2/usb.c | 1 + .../wireless/mediatek/mt76/mt76x2/usb_init.c | 2 +- .../wireless/mediatek/mt76/mt76x2/usb_main.c | 6 + drivers/net/wireless/mediatek/mt76/usb.c | 7 +- 22 files changed, 582 insertions(+), 329 deletions(-) create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x02_beacon.c -- 2.20.1
