On Thu, Feb 28, 2019 at 12:37:48PM +0100, Lorenzo Bianconi wrote: > > On Thu, Feb 28, 2019 at 12:08:45PM +0100, Lorenzo Bianconi wrote: > > > Grab rx_page_lock in mt76u_refill_rx allocating rx buffer for 'legacy' > > > mode. Remove gfp from mt76u_refill_rx signature since we need to > > > use GFP_ATOMIC > > > > > > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > > > > I'm doing some cleanup/optimization work which amongs other things > > will remove rx_page_lock. Please drop this patch. > > Oh, ok. IIRC we need rx_page_lock to fix this: > 481bb0432414f790066205fe77226b7d1877385d. Is it still necessary? > Moreover maybe we need this patch for 5.1 since net-next is almost close, no? It is not neccessery now in -next after removing concurrent access to mt76u_buf_alloc(), can be removed. Stanislaw