Search Linux Wireless

Re: [RFC 07/12] mt76x02: fix hdr pointer in write txwi for USB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Since we add txwi at the begining of skb->data, it no longer point
> to ieee80211_hdr. This breaks settings TS bit for probe response and
> beacons.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c
> index fdd6a021914d..bcf3126efda9 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c
> @@ -85,8 +85,9 @@ int mt76x02u_tx_prepare_skb(struct mt76_dev *mdev, void *data,
>  
>  	mt76x02_insert_hdr_pad(skb);
>  
> -	txwi = skb_push(skb, sizeof(struct mt76x02_txwi));
> +	txwi = (struct mt76x02_txwi *)(skb->data - sizeof(struct mt76x02_txwi));
>  	mt76x02_mac_write_txwi(dev, txwi, skb, wcid, sta, len);
> +	skb_push(skb, sizeof(struct mt76x02_txwi));
>  
>  	pid = mt76_tx_status_skb_add(mdev, wcid, skb);
>  	txwi->pktid = pid;
> -- 
> 2.20.1
> 

Good catch :)
I think we should post it ontop of wireless-drivers since sw encryption is not
working now.

Acked-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux