On 11/21/18 12:03 PM, Manikanta Pubbisetty wrote:
> As per the current design, for sw crypto controlled devices, it is
> the device which has to advertise the support for AP/VLAN iftype
> based on it's capability to tranmsit packets encrypted in software
> (In VLAN functionality, group traffic generated for a specific
> VLAN group is always encrypted in software). Commit db3bdcb9c3ff
> ("mac80211: allow AP_VLAN operation on crypto controlled devices")
> has introduced this change.
>
> Since 4addr AP operation also uses AP/VLAN iftype, this conditional
> way of advertising AP/VLAN support has broken 4addr AP mode operation on
> crypto controlled devices which do not support VLAN functionality.
>
> For example:
> In the case of ath10k driver, not all firmwares have support for VLAN
> functionality but all can support 4addr AP operation. Because AP/VLAN
> support is not advertised for these devices, 4addr AP operations are
> also blocked.
>
> Fix this by allowing 4addr opertion on devices which do not advertise
> AP/VLAN iftype but which can support 4addr operation (the desicion is
> taken based on the wiphy flag WIPHY_FLAG_4ADDR_AP).
>
> Fixes: Commit db3bdcb9c3ff ("mac80211: allow AP_VLAN operation on
> crypto controlled devices")
> Signed-off-by: Manikanta Pubbisetty <mpubbise@xxxxxxxxxxxxxx>
> ---
> include/net/cfg80211.h | 3 ++-
> net/mac80211/util.c | 4 +++-
> net/wireless/core.c | 9 +++++++--
> net/wireless/nl80211.c | 10 ++++++++--
> 4 files changed, 20 insertions(+), 6 deletions(-)
>
Hi Manikanta,
Will you send an updated version of this patch to mainline?
Multiple people ran into this problem in OpenWrt and it would be nice if
such a fix would be included in upstream kernel.
See here a pull request:
https://github.com/openwrt/openwrt/pull/1640
Hauke
