Hi Surabhi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ath6kl/ath-next] [also build test WARNING on v5.0-rc4 next-20190222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Surabhi-Vishnoi/Fix-inconsistencies-observed-in-population-of-tx_stats-in-debugfs/20190225-041038 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next config: x86_64-fedora-25 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): In file included from include/linux/bitops.h:19:0, from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/completion.h:12, from drivers/net/wireless/ath/ath10k/core.h:11, from drivers/net/wireless/ath/ath10k/htt_rx.c:8: drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_update_per_peer_tx_stats': >> arch/x86/include/asm/bitops.h:325:37: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] return ((1UL << (nr & (BITS_PER_LONG-1))) & ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (addr[nr >> _BITOPS_LONG_SHIFT])) != 0; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ drivers/net/wireless/ath/ath10k/htt_rx.c:2916:16: note: 'flags' was declared here unsigned long flags; ^~~~~ -- In file included from include/linux/bitops.h:19:0, from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/completion.h:12, from drivers/net//wireless/ath/ath10k/core.h:11, from drivers/net//wireless/ath/ath10k/htt_rx.c:8: drivers/net//wireless/ath/ath10k/htt_rx.c: In function 'ath10k_update_per_peer_tx_stats': >> arch/x86/include/asm/bitops.h:325:37: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] return ((1UL << (nr & (BITS_PER_LONG-1))) & ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (addr[nr >> _BITOPS_LONG_SHIFT])) != 0; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ drivers/net//wireless/ath/ath10k/htt_rx.c:2916:16: note: 'flags' was declared here unsigned long flags; ^~~~~ vim +/flags +325 arch/x86/include/asm/bitops.h 1c54d770 include/asm-x86/bitops.h Jeremy Fitzhardinge 2008-01-30 321 117780ee arch/x86/include/asm/bitops.h H. Peter Anvin 2016-06-08 322 static __always_inline bool constant_test_bit(long nr, const volatile unsigned long *addr) 1c54d770 include/asm-x86/bitops.h Jeremy Fitzhardinge 2008-01-30 323 { 9b710506 arch/x86/include/asm/bitops.h H. Peter Anvin 2013-07-16 324 return ((1UL << (nr & (BITS_PER_LONG-1))) & 9b710506 arch/x86/include/asm/bitops.h H. Peter Anvin 2013-07-16 @325 (addr[nr >> _BITOPS_LONG_SHIFT])) != 0; 1c54d770 include/asm-x86/bitops.h Jeremy Fitzhardinge 2008-01-30 326 } 1c54d770 include/asm-x86/bitops.h Jeremy Fitzhardinge 2008-01-30 327 :::::: The code at line 325 was first introduced by commit :::::: 9b710506a03b01a9fdd83962912bc9d8237b82e8 x86, bitops: Change bitops to be native operand size :::::: TO: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx> :::::: CC: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
