Search Linux Wireless

Re: [PATCH] mt76: usb: fix warning in mt76u_buf_free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> lorenzo@xxxxxxxxxx writes:
> 
> > From: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> >
> > Fix following static checker warning in mt76u_buf_free:
> >   drivers/net/wireless/mediatek/mt76/usb.c:372 mt76u_buf_free()
> >   warn: address of 'urb->sg[i]' is non-NULL
> >
> > There is no need to check sg page pointer since urb->num_sgs
> > has been already validated in mt76u_fill_rx_sg
> >
> > Fixes: cb83585e1121 ("mt76: usb: fix possible memory leak in mt76u_buf_free")
> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> 
> The merge window is really close, should I take this directly to
> wireless-drivers-next?

Hi Kalle,

I think this patch can go in Felix's tree for the moment since it just fixes the warning,
the intended behaviour is to run skb_free_frag()

Regards,
Lorenzo

> 
> BTW, Lorenzo please add your name to SMTP From line to make threading
> cleaner:
> 
> From:   lorenzo@xxxxxxxxxx
> 
> -- 
> Kalle Valo

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux