Lubomir Rintel <lkundrak@xxxxx> wrote: > We'll need to talk to the firmware to get a hardware address before > device is registered with ieee80211 subsystem at the end of > lbtf_add_card(). Hooking the callbacks after that is too late. > > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx> > Reviewed-by: Steve deRosier <derosier@xxxxxxxxxxxxxx> Failed to compile: drivers/net/wireless/marvell/libertas_tf/main.c: In function 'lbtf_add_card': drivers/net/wireless/marvell/libertas_tf/main.c:603:309: error: 'udev' undeclared (first use in this function); did you mean 'cdev'? lbtf_deb_usbd(&udev->dev, "Error programming the firmware\n"); ^ cdev drivers/net/wireless/marvell/libertas_tf/main.c:603:309: note: each undeclared identifier is reported only once for each function it appears in make[5]: *** [drivers/net/wireless/marvell/libertas_tf/main.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [drivers/net/wireless/marvell/libertas_tf] Error 2 make[3]: *** [drivers/net/wireless/marvell] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [drivers/net/wireless] Error 2 make[1]: *** [drivers/net] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 3 patches set to Changes Requested. 10804885 [1/3] libertas_tf: move hardware callbacks to a separate structure 10804881 [2/3] libertas_tf: don't defer firmware loading until start() 10804883 [3/3] libertas_tf: get the MAC address before registering the device -- https://patchwork.kernel.org/patch/10804885/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches