Rafał Miłecki <zajec5@xxxxxxxxx> writes: > On Fri, 15 Feb 2019 at 11:04, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: >> Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: >> >> > Hi Rafał, >> > >> > url: >> > https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/brcmfmac-use-bphy_err-in-all-wiphy-related-code/20190214-140004 >> > base: >> > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git >> > master >> > >> > smatch warnings: >> > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c:114 >> > brcmf_fweh_call_event_handler() warn: variable dereferenced before >> > check 'ifp' (see line 110) >> > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c:187 >> > brcmf_fweh_handle_if_event() error: we previously assumed 'ifp' could >> > be null (see line 184) >> > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c:189 >> > brcmf_fweh_handle_if_event() warn: variable dereferenced before check >> > 'ifp' (see line 187) >> > >> > # https://github.com/0day-ci/linux/commit/e12dba9f5ed77216c5984a4b57ddc31ba23376c9 >> > git remote add linux-review https://github.com/0day-ci/linux >> > git remote update linux-review >> > git checkout e12dba9f5ed77216c5984a4b57ddc31ba23376c9 >> > vim +/ifp +114 drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c >> > >> > 5c36b99a drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van >> > Spriel 2012-11-14 104 >> > 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van >> > Spriel 2012-11-14 105 static int brcmf_fweh_call_event_handler(struct >> > brcmf_if *ifp, >> > 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van >> > Spriel 2012-11-14 106 enum brcmf_fweh_event_code code, >> > 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van >> > Spriel 2012-11-14 107 struct brcmf_event_msg *emsg, >> > 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van >> > Spriel 2012-11-14 108 void *data) >> > 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van >> >> This report is very hard to read as the lines seem to be wrapped. > > I think it's your client playing tricks on you. I got the report > correctly formatted and so did patchwork: > https://patchwork.kernel.org/comment/22483031/ Now that's weird, Gnus has never failed me like this before. And I remember I didn't have this problem with Dan's previous report few days ago and all the other reports before that. Oh well, no time to investigate so have to hope that this line wrapping magically disappears as it appeared :) -- Kalle Valo
