On Wed, Feb 13, 2019 at 01:50:20PM +0100, Julia Lawall wrote: > Perhaps a return is needed after line 436. I don't think so. The kfree only occurs in the case where the hash table insertion fails. While we should only return an error if both the hash table insertion failed and the error is not due to an existing entry (EEXIST). Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt