On Wed, Jul 23, 2008 at 10:15 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Wed, Jul 23, 2008 at 10:01:37AM -0700, Luis R. Rodriguez wrote: >> On Wed, Jul 23, 2008 at 10:00 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: >> > On Wed, Jul 23, 2008 at 09:57:31AM -0700, Luis R. Rodriguez wrote: >> >> I take it we made it too late for .27? >> > >> > Well, we decided to put driver in anytime in the process, so if the >> > driver is cleaned up enough in the next month or so it should be able >> > to make it. >> >> Great! We are committed so let me know if you find other critical >> areas of cleanups you'd like to see. > > Let's start with some easy ones that might not be critical by itself > but help making the driver look like a normal Linux driver: > > - replace enum hal_bool with the normal bool type > - replace A_MAX usage with the normal max/max_t macros > - just use ASSERT instead of assert > - think about doing the same for KASSERT > - kill memzero > - kill get_dma_mem_context and copy_dma_mem_context > - replace the various debug message print helpers with standard > Linux infrastructure We'll get cracking on this. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
