> On 2019-02-06 10:15, Lorenzo Bianconi wrote: > > Move mt76_tx_queue_mcu routine in dma.c and remove duplicated code. > > mt76_tx_queue_mcu will be reused adding support for mt7603 driver > > > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxx> > I think we should rename this function, since it's going to be used for > more than just MCU commands. > Maybe mt76_dma_tx_queue_skb_raw (and add corresponding queue_op instead > of direct calls)? > While you're at it, maybe you could also remove mt76_queue_add_buf and > the corresponding queue op. ack, will fix it in v2 Regards, Lorenzo > > - Felix