"Rafał Miłecki" <rafal.milecki@xxxxxxxxx> writes: > From: Rafał Miłecki <rafal@xxxxxxxxxx> > > So far __brcmf_err() was using pr_err() which didn't allow identifying > device that was affected by an error. It's crucial for systems with more > than 1 device supported by brcmfmac (a common case for home routers). > > This change allows passing struct brcmf_bus to the __brcmf_err(). That > struct has been agreed to be the most common one. It allows accessing > struct device easily & using dev_err() printing helper. > > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> > Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> > --- > V2: Add missing #include <linux/device.h> > V3: Add #include "bus.h" to fix CONFIG_BRCM_TRACING=y compilation error: > error: dereferencing pointer to incomplete type 'struct brcmf_bus' Thanks, this compiles for me now. I also pushed this to w-d-next pending branch to get more build coverage from kbuild bot. -- Kalle Valo